[PATCH] Non-DMA mode for floppy on PowerPC, new version

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Mar 9 15:03:33 EST 2005

On Thu, 2005-02-24 at 11:53 -0500, Pavel Fedin wrote:
>  Here is a cleaned up version of my 2.6.8 kernel patch.
> .../...

Where is "can_use_virtual_dma" defined ? I think that should be made
a bit more clean. Except for that, it looks ok I suppose (my knowledge
of this legacy cruft is quite poor :)

Also, do you need to re-implement your own allocation routine ? Just
use get_dma_pages in both...

A pure style issue also: your static initialization should use C99
initializers (.field = value)

"fd_routine" could be renamed to something nicer, like fd_dma_ops (more

I haven't looked at the logic of the vdma code itself, I suppose that if
it works, it's good enough :)


More information about the Linuxppc-dev mailing list