[PATCH] use correct register names in arch/ppc/kernel/relocate_kernel.S
Benjamin Herrenschmidt
benh at kernel.crashing.org
Thu Jun 30 09:54:44 EST 2005
On Wed, 2005-06-29 at 20:08 +0200, Segher Boessenkool wrote:
> > --- linux-2.6.13-rc1.orig/arch/ppc/kernel/relocate_kernel.S
> > +++ linux-2.6.13-rc1/arch/ppc/kernel/relocate_kernel.S
> > @@ -34,9 +34,9 @@ relocate_new_kernel:
> >
> > mr r8, r0
> > ori r8, r8, MSR_RI|MSR_ME
> > - mtspr SRR1, r8
> > + mtspr SPRN_SRR1, r8
> > addi r8, r4, 1f - relocate_new_kernel
> > - mtspr SRR0, r8
> > + mtspr SPRN_SRR0, r8
> > sync
> > rfi
>
> Or just mtsrr0 c.q. mtsrr1
They are lovely but shits me when I grep for SPRN_SRR0 :) I tend to
prefer consistency here and so if we start using mtsrr0/1, then we
should change the whole kernel at once and not have a mix of SPRN_* and
mt*
Ben.
More information about the Linuxppc-dev
mailing list