DTC: write_dt_blob() question
Jon Loeliger
jdl at freescale.com
Thu Jul 14 02:16:32 EST 2005
David,
Over in flattree.c's write_dt_blob() there is this code:
make_bph(&bph, vi, reservenum, dtbuf.len, strbuf.len);
/* Align the reserve map to an 8 byte boundary */
for (i = vi->hdr_size; i < be32_to_cpu(bph.off_mem_rsvmap); i++)
fputc(0, f);
fwrite(&bph, vi->hdr_size, 1, f);
for (i = 0; i < reservenum+1; i++)
fwrite(&re, sizeof(re), 1, f);
However, I think the boot_param_header should be emitted
first, before the alignment:
make_bph(&bph, vi, reservenum, dtbuf.len, strbuf.len);
fwrite(&bph, vi->hdr_size, 1, f);
/* Align the reserve map to an 8 byte boundary */
for (i = vi->hdr_size; i < be32_to_cpu(bph.off_mem_rsvmap); i++)
fputc(0, f);
for (i = 0; i < reservenum+1; i++)
fwrite(&re, sizeof(re), 1, f);
Thoughts?
Thanks,
jdl
More information about the Linuxppc-dev
mailing list