[RFC] Option to disable mapping genrtc calls to ppc_md calls
Mark A. Greer
mgreer at mvista.com
Fri Jan 21 10:54:04 EST 2005
Benjamin Herrenschmidt wrote:
>The patch is going backward since it disables the ability to have
>runtime selection of the RTC chip.
Its only "backwards" from a narrow PPC point of view. Without a major
rewrite of the rtc infrastructure, these are the choices:
a) Make a ppc-only solution using ppc_md.xxx.
b) Make a generic solution either by writing an entire driver
duplicating code that's in genrtc (e.g., ds1302) or interface to the
bottom of genrtc (e.g., my rtc code). The only limitation is that you
can't select different rtc chips at runtime.
Choosing a) give you more flexibility within PPC but is PPC only;
choosing b) is generic but assumes its the only rtc chip that will be
used by whatever kernel binary its put in.
I chose b) and to reuse the genrtc code. In a sane world, reusing code
is considered a good thing...
Its obvious that you and Tom prefer a). That's fine but if I switch to
a), I know the first comment I'll get when I post the driver to lmkl
will be, "Why would you make this ppc-specific when you could have made
it generic?" Will you and Tom then defend that decision for me?
Also, this is not board-specific as you and Tom have tried to suggest.
Assuming I change the #ifdef in rtc.h to remove the option as I think
Tom and I are agreeing upon, you select the i2c algo/adapter, the
i2c/rtc client and its there. Where are the "gross hacks for every board"?
More information about the Linuxppc-dev