[PATCH] Non-DMA mode for floppy on PowerPC

Hollis Blanchard hollis at penguinppc.org
Wed Feb 23 02:56:03 EST 2005

On Feb 22, 2005, at 12:06 PM, Pavel Fedin wrote:

> On Tue, 22 Feb 2005 01:32:09 -0800
> Eugene Surovegin <ebs at ebshome.net> wrote:
>> Please, be patient and don't repost the same stuff every day.
>  Ok. How long does it take for a patch to get included into the 
> kernel? I posted if two weeks ago for the first time and nothing 
> happened. In LKML also nobody answers.

That generally means nobody cares (don't worry, we've all been there).

In your case, I would start by very clearly describing exactly why you 
can't use DMA on Pegasos, and why the current code is unusable. Can a 
PC floppy run in non-DMA mode? If so, your patch should probably be for 
floppy.c rather than asm-ppc/floppy.h . I notice there is already code 
for "virtual DMA mode" in floppy.c, apparently for when there is no 
memory available in the DMA zone. Why doesn't that code work for you?

As for code style, it seems that "TRACE_FLPY_INT" is something you 
invented. It hurts readability; I'd remove it. Drop that "register" 
stuff. Make your whitespace consistent (for example, add spaces after 
"if" and "for").


More information about the Linuxppc-dev mailing list