[PATCH] sungem update

David S. Miller davem at davemloft.net
Wed Feb 9 11:40:42 EST 2005

On Tue, 18 Jan 2005 17:10:14 +1100
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

> This patch updates the sungem driver. I reworked all of the PM stuff, making it
> less prone to races, probably simpler to read as well, and I no longer shut the
> PHY down when the interface is down so that things like laptop-net no longer
> die (the gain in power consumption was minimal, not worth the pain). I also
> implemented basic WOL support.
> There is still something I'm not totally happy with in the locking
> (explained in the comment at the beginning), basically too much locking and a
> couple of places with delays in locks. I will try to improve these later on.
> If you are happy with this, please forward to Linus/Andrew asap
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Sorry for taking so long to review this :-/

This looks fine, except for one thing.  The WOL_* registers don't exist
in the Sun variants of the GEM chip, so it's not safe to try and program
them on all chips blindly like these changes do.  Perhaps some bit test

	if (pdev->vendor != PCI_VENDOR_ID_SUN)
		gp->flags |= GEM_HAS_WOL;

Then protect all the WOL_* register programming with this new

More information about the Linuxppc-dev mailing list