[PATCH] remove .tmp_gas_check

Tom Rini trini at kernel.crashing.org
Mon Feb 7 09:43:06 EST 2005


On Sun, Feb 06, 2005 at 10:56:00PM +0100, Olaf Hering wrote:
>  On Sun, Feb 06, Tom Rini wrote:
> 
> > On Sun, Feb 06, 2005 at 10:15:06PM +0100, Olaf Hering wrote:
> > 
> > >  On Sun, Feb 06, Tom Rini wrote:
> > > 
> > > > I agree you shouldn't have to see it.  I'm saying the problem is the
> > > > variable shouldn't be evaluated.
> > > 
> > > This patch seems to work for me.
> > 
> > What I don't like is that checkbin shouldn't be evaluated for 'tags' or
> > other non-compile targets, so you don't need those explicit rm's.  Also,
> > you forgot the signed-off-by line :)
> 
> Why should make tags or oldconfig ever care about the installed toolchain?

It shouldn't, and 'tags' at least shouldn't depend on 'checkbin'
(oldconfig I _believe_ actually invokes HOSTCC and creates other .tmp
files, but I don't have a tree handy).

> How should the tmpfile disappear if one calls make checkbin with success?

On make clean, like the other .tmp files that are around at the end of a
kernel compile (kallsyms/modules/maybe something else).

> Maybe I misunderstood you.

I think so.  We both agree there should be no ppc-specific .tmp files
around after certain make targets.  I'm saying that there's always some
.tmp files generated on every arch for certain targets, and removed with
a clean.  PPC should only create .tmp files (And leave them alone) in
the cases where every arch generates some .tmp files.

-- 
Tom Rini
http://gate.crashing.org/~trini/



More information about the Linuxppc-dev mailing list