[PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
Eugene Surovegin
ebs at ebshome.net
Sun Dec 4 11:12:05 EST 2005
On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
> Eugene Surovegin <ebs at ebshome.net> wrote:
> >
> > > +extern void __init btext_init(boot_infos_t *bi);
> > > extern void btext_welcome(void);
> > > extern void btext_prepare_BAT(void);
> > > extern void btext_setup_display(int width, int height, int depth, int pitch,
> >
> > "__init" should be placed between closing brace and semicolon. For
> > more info, see include/linux/init.h
>
> I don't think it matters much. Often we just omit it from the declaration
> - it's only required at the definition site
Quite likely it doesn't matter, but I think we should follow existing
style, if not for correctness, but at least for consistency (it
actually caught my eye exactly because it _looked_ different). I'm
pretty sure original poster have tested original version :).
--
Eugene
More information about the Linuxppc-dev
mailing list