[PATCH 3/3] Move all the very similar files

Brad Boyer flar at allandria.com
Thu Aug 25 06:44:33 EST 2005


On Wed, Aug 24, 2005 at 01:13:32PM -0700, Tom Rini wrote:
> On Wed, Aug 24, 2005 at 10:03:26PM +0200, Arnd Bergmann wrote:
> > On Middeweken 24 August 2005 20:20, Tom Rini wrote:
> > > No it doesn't.  You can easily make the drivers get the includes from
> > > <platforms/pmac/foo.h>, arch/$(ARCH) is already always in the search
> > > path, I believe (if not, it's easy to add Makefile things to get it).
> > 
> > I don't think any architecture except ppc32 has traditionally had
> > arch/$ARCH in its include path, and it would probably come as a surprise
> > to many kernel developers if this were used more.
> 
> True, but it's possible that the pmac drivers could also be converted to
> use something else to pass around infos, register IO and such so the
> headers can still live in arch/powerpc/platforms/pmac/

These days, the macio bus is a real device-model bus. The code still
lives in drivers/macintosh, but it will be used by more than just
pmac machines whenever I get the 68k mac support finished. It seems
like we really should have an include/linux/macio.h, and make the
whole thing act more like a normal bus. I would like to abstract out
more of it anyway, particularly the DMA support. That way we wouldn't
have several different drivers for the same chip due to bus interface
differences (see mace.c and macmace.c for an example of current practice).
This would eliminate at least macio.h and dbdma.h. Hopefully it would
get most of the mac specific code organized in a more logical fashion.
Any comments/requirements/suggestions?

	Brad Boyer
	flar at allandria.com




More information about the Linuxppc-dev mailing list