[PATCH] Use platform device for 8250 registration

Tom Rini trini at kernel.crashing.org
Thu Aug 18 01:05:36 EST 2005


On Wed, Aug 17, 2005 at 08:31:11AM +0100, David Woodhouse wrote:
> On Wed, 2005-08-17 at 01:30 -0500, Kumar Gala wrote:
> > > We could probably remove all the rest of the crap from asm/serial.h and
> > > let platforms register their own serial8250 platform devices...
> 
> > Hmm, I wondering if we can provide some standard way of handling this  
> > for the embedded platforms as well.  It would be nice to drop the old  
> > style of initialization completely and move to using a platform  
> > device always.
> 
> Yes, that's precisely what I meant. Just remove it from the list in
> serial.h and as Ben says, instantiating a platform device is easy.
> 
> static struct plat_serial8250_port my_serial_ports[] = {
> 	{
> 		.uartclk = 115200*16,
> 		.iobase = 0x2f8,
> 		.irq = 3,
> 		.flags = ASYNC_BOOT_AUTOCONF;
> 	},
> };

So long as you convert arch/ppc/boot/ to this as well, why not (or at
least being able to grab the infos from these structs somehow).

Once everyone is on a flat tree, I don't object to killing all of the
old-style uart definitions steaming out of <asm-ppc/serial.h>.

-- 
Tom Rini
http://gate.crashing.org/~trini/



More information about the Linuxppc-dev mailing list