[PATCH 2.6.12-rc3] pmac: save master volume on sleep

Benjamin Herrenschmidt benh at kernel.crashing.org
Fri Apr 22 10:17:14 EST 2005

On Thu, 2005-04-21 at 20:04 +0200, Colin Leroy wrote:
> Hi,
> Ben's patch that shutdowns master switch and restores it after
> resume ("pmac: Improve sleep code of tumbler driver") isn't enough here
> on an iBook (snapper chip).
> The master switch is correctly saved and restored, but somehow
> tumbler_put_master_volume() gets called just after
> tumbler_set_master_volume() and sets mix->master_vol[*] to 0. So, on
> resuming, the master switch is reenabled, but the volume is set to 0.
> Here's a patch that also saves and restores master_vol.
> Thanks,

Looks good.


More information about the Linuxppc-dev mailing list