[PATCH] drivers/macintosh: Remove redundant NULL check before kfree

Jesper Juhl juhl-lkml at dif.dk
Sun Apr 17 02:20:30 EST 2005


This patch removes a redundant NULL check before kfree() - kfree handles 
NULL pointers just fine so there's no need to check first.

Signed-off-by: Jesper Juhl <juhl-lkml at dif.dk>
---

 drivers/macintosh/adbhid.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)


--- linux-2.6.12-rc2-mm3-orig/drivers/macintosh/adbhid.c	2005-03-02 08:38:33.000000000 +0100
+++ linux-2.6.12-rc2-mm3/drivers/macintosh/adbhid.c	2005-04-16 18:00:10.000000000 +0200
@@ -806,8 +806,7 @@ adbhid_input_register(int id, int defaul
 static void adbhid_input_unregister(int id)
 {
 	input_unregister_device(&adbhid[id]->input);
-	if (adbhid[id]->keycode)
-		kfree(adbhid[id]->keycode);
+	kfree(adbhid[id]->keycode);
 	kfree(adbhid[id]);
 	adbhid[id] = NULL;
 }



-- 
Jesper Juhl

PS. Sorry about the long CC list, but I was unsure who to send this to.
Please CC me on replies.






More information about the Linuxppc-dev mailing list