thoughts and questions on 8xx patches

[Robert P. J. Day]

   rather than get into more detailed discussion on microcode patches, 
here's a (partial) patch that represents what i'd really, really, 
*really* like to see.

==========================================================================
--- linuxppc-2.5/arch/ppc/8xx_io/Kconfig	2004-09-21 05:54:40.112334040 -0400
+++ linuxppc-2.5-new/arch/ppc/8xx_io/Kconfig	2004-09-21 06:00:56.836063328 -0400
@@ -140,13 +140,23 @@

  	  If in doubt, say N here.

-config UCODE_PATCH
-	bool "I2C/SPI Microcode Patch"
-	help
-	  Motorola releases microcode updates for their 8xx CPM modules.  The
-	  microcode update file has updates for IIC, SMC and USB.  Currently only
-	  the USB update is available by default, if the MPC8xx USB option is
-	  enabled.  If in doubt, say 'N' here.
+choice
+	prompt "Microcode patch selection"
+	default NO_UCODE_PATCH
+
+config NO_UCODE_PATCH
+	bool "None"
+
+config USB_SOF_PATCH
+	bool "USB SOF patch"
+
+config I2C_SPI_PATCH
+	bool "I2C/SPI relocation patch"
+
+config I2C_SPI_SMC1_PATCH
+	bool "I2C/SPI/SMC1 relocation patch"
+
+endchoice

  endmenu
==========================================================================

   it adds a simple choice entry to the MPC8xx menu, from which you can 
select the appropriate patch -- it's as easy as that.

   note that that's not the entire list of possible patches -- i have 
the list from wolfgang's tree that distinguishes between 850 and 8xx 
(non-850) patches in some cases so the list is actually longer than 
this one.  but, really, selecting a patch should be this easy -- pick 
one and check the box.  and this makes it trivial to add or delete 
patches appropriately as time goes by.

   obviously, this menu requires changes in the underlying micropatch.c 
file (which aren't shown here), but i'm curious about whether this 
approach would overly offend anyone.

   i'm willing to create the overall patch to support this, but not if 
it's just going to be tossed because of philosophical positions.


rday