[PReP][PATCH] Fix ISA PIC interrupt acknowledge address detection

Leigh Brown leigh at solinno.co.uk
Fri Sep 17 04:25:31 EST 2004


The ISA PIC address for acknowledging interrupts is actually defined
in residual data as a 32-bit system address, rather than a 32-bit 
memory address.  This is rather embarrasing, as I don't think this
function has done the right thing, ever.

Tested and working fine on my Carolina and 140.

Thanks,

Leigh.

Signed-off-by: Leigh Brown <leigh at solinno.co.uk>

--- arch/ppc/platforms/residual.c.orig	2004-09-14 20:50:16.000000000 +0100
+++ arch/ppc/platforms/residual.c	2004-09-14 20:50:29.000000000 +0100
@@ -935,8 +935,8 @@
 		goto unknown;
 
 #define p pkt->L4_Pack.L4_Data.L4_PPCPack
-	/* Must be 32-bit memory address */
-	if (!((p.PPCData[0] == 2) && (p.PPCData[1] == 32)))
+	/* Must be 32-bit system address */
+	if (!((p.PPCData[0] == 3) && (p.PPCData[1] == 32)))
 		goto unknown;
 
 	/* It doesn't seem to work where length != 1 (what can I say? :-/ ) */



More information about the Linuxppc-dev mailing list