[PATCH] fix missing option in binutils version check

Tom Rini trini at kernel.crashing.org
Wed Jun 16 02:12:58 EST 2004

On Mon, Jun 14, 2004 at 11:19:31PM +0200, Olaf Hering wrote:

>  On Mon, Jun 14, Tom Rini wrote:
> > ... except that we can have 'dssall' even when CONFIG_ALTIVEC=n, so we
> > need it really on CONFIG_6xx.
> switch_mm() has it in CONFIG_ALTIVEC, so checking for CONFIG_ALTIVEC=y
> looks correct to me.

arch/ppc/kernel/l2cr.S unconditionally has 'dssall', and this file is
compiled on all CONFIG_6xx builds.

> > But more importantly, why did you break the check to stop people with
> > broken binutils from trying to compile the kernel, and not fix the rest
> > of the breakage ?
> What exactly is broken in the old binutils?

They do not understand 'dssall' (and a few other) instructions.  So in
2.4 we didn't call them directly, but had something along the lines of:
#ifndef DSSALL
#define DSSALL 0x........

Using dssall was just a choice of convenience.

Tom Rini

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc-dev mailing list