[PATCH] therm_* drivers need i2c-keywest

Geert Uytterhoeven geert at linux-m68k.org
Fri Jan 16 23:03:25 EST 2004


On Fri, 16 Jan 2004, Colin Leroy wrote:
> On 16 Jan 2004 at 12h01, Colin Leroy wrote:
> > This patch lets the different pmac thermostat drivers try to load
> > i2c-keywest if necessary and possible.
>
> As I didn't saw that request_module() errors if the module is already loaded (heh.), a better version of this is to avoid checking return value...
> See attached.

And you want to drop the #ifdef CONFIG_KMOD, since that's already in
<linux/kmod.h>.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-dev mailing list