[PATCH] Fix Alsa issues including Oopses with OSS emulation

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Dec 23 05:13:13 EST 2004


This patch (which will be send upstream separately by the Alsa folks) fixes
an signed vs. unsigned char problem in Alsa which was the cause of the Oops
people were experiencing on ppc with OSS emulation and possibly other issues.

Index: linux-work/sound/core/pcm_misc.c
===================================================================
--- linux-work.orig/sound/core/pcm_misc.c	2004-11-22 01:51:09.000000000 +0100
+++ linux-work/sound/core/pcm_misc.c	2004-12-22 19:11:26.297518336 +0100
@@ -26,10 +26,10 @@
 #define SND_PCM_FORMAT_UNKNOWN (-1)
 
 struct pcm_format_data {
-	char width;	/* bit width */
-	char phys;	/* physical bit width */
-	char le;	/* 0 = big-endian, 1 = little-endian, -1 = others */
-	char signd;	/* 0 = unsigned, 1 = signed, -1 = others */
+	signed char width;	/* bit width */
+	signed char phys;	/* physical bit width */
+	signed char le;		/* 0 = big-endian, 1 = little-endian, -1 = others */
+	signed char signd;	/* 0 = unsigned, 1 = signed, -1 = others */
 	unsigned char silence[8];	/* silence data to fill */
 };
 





More information about the Linuxppc-dev mailing list