linuxppc-2.5 patch for KGDB in arch/ppc/kernel ppc-stub.c

[Mark A. Greer]

This is an untested patch for 2.5.

The following patch fixes 2 problems with KGDB:

a) On line 617, '&regs' should be 'regs' in the call to mem2hex().  The
resulting improper response packet confuses the GDB client resulting in
step/next and stepi/nexti GDB commands to "lose their grip" and allow
execution to continue unchecked.

b) When executing an 's' command, we don't want to start single stepping
until we *return** from the current exception that we're handling.
Therefore, the MSR_SE bit should not be set in the MSR until the rfi
from this exception is executed (i.e., only need to set that bit in
'regs->msr' and not do an actual 'mtmsr()' at this point).  If the
'mtmsr(msr | MSR_SE);' line is executed at this point, a single-step
exeption will occur inside the exception handler itself which causes
another exception and the 'printk(KERN_ERR "interrupt while in kgdb,
returning\n");' line at the beginning of handle_exception() to be
executed.  Not fatal but somewhat disturbing to see.

Mark
--
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kgdb_2_5.diff
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20030311/69a7db4a/attachment.asc>