Mark A. Greer mgreer at
Fri Apr 12 05:10:21 EST 2002

Michael Sokolov wrote:

> I have replaced gt64260_common.c with gt64260_data.c and gt64260_utils.c so
> that one can choose to use the utility functions for non-OF non-StarMON boards
> or not use them for good OF/StarMON, but still always have the crucial global
> variables.
> <snip>
> Then fine, keep that library and use it for your ports to your heart's delight.
> Just please let HEC ports not use it.

You never _had_ to use the gt64260_common code if you didn't want to.  Its just a
library of stuff there to be used (but I would expect most if not all boards with a
gt64260 to use many of the functions in it).  If you don't want to, that's fine.

My issue is that your gt64260_utils.c doesn't have a lot of functionality that
_common.c does.

I guess I still don't know what you want.  Do you want your _data.c and _utils.c pushed
too or instead of _common.c?  Either way, why not use the functions that are already in
_common.c instead?  If that functionality isn't there, add it.  If its the size of
gt64260_common.c, then it can be broken up.  I would already like to move the
find_bridges, bridge_init, and check_errata routines into their own file.  Doesn't
reduce the size that much but it splits it up a little so you can not link the .o file
with find_bridges, etc code if you don't want it, for example.


** Sent via the linuxppc-dev mail list. See

More information about the Linuxppc-dev mailing list