Patch: Fix SMP hang on modem close

roger blofeld blofeldus at yahoo.com
Sat Apr 6 06:20:21 EST 2002


Ben,
 This patch removes two dangling LOCK() statements for
core99/pangea. The core99 one hung my dual g4.
-roger

--- linux/arch/ppc/kernel/pmac_feature.c.orig   Tue
Apr  2 08:17:31 2002
+++ linux/arch/ppc/kernel/pmac_feature.c        Fri
Apr  5 14:02:13 2002
@@ -788,7 +788,7 @@
                UNLOCK(flags); mdelay(250);
LOCK(flags);
                MACIO_OUT8(KL_GPIO_MODEM_RESET, gpio |
KEYLARGO_GPIO_OUTOUT_DATA);
                (void)MACIO_IN8(KL_GPIO_MODEM_RESET);
-               UNLOCK(flags); mdelay(250);
LOCK(flags);
+               UNLOCK(flags); mdelay(250);
        }
        return 0;
 }
@@ -1445,7 +1445,7 @@
                UNLOCK(flags); mdelay(250);
LOCK(flags);
                MACIO_OUT8(KL_GPIO_MODEM_RESET, gpio |
KEYLARGO_GPIO_OUTOUT_DATA);
                (void)MACIO_IN8(KL_GPIO_MODEM_RESET);
-               UNLOCK(flags); mdelay(250);
LOCK(flags);
+               UNLOCK(flags); mdelay(250);
        }
        return 0;
 }


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-dev mailing list