Problem serial.c on module

[Tom Rini]

On Fri, Sep 28, 2001 at 02:33:01PM +0900, KOBAYASHI R. Taizo wrote:

> I examined this problem and had a question.
> Dose it need following branch?
> ================L5375==
> #ifdef CONFIG_ALL_PPC
>         /* early PowerMacs would machine check */
>         if (_machine == _MACH_Pmac) {
>                 printk(KERN_INFO "serial.c: nothing to do on PowerMacs.\n");
>                 return 0;
>         }
> #endif
> =======================

Some older machines apparently do.  The current 'workaround' in 2_4 is
#if defined(CONFIG_ALL_PPC) && !defined(MODULE).

> Anyway, pcmcia modem card on my TiBook seems work fine with following patch.
> --- linux/drivers/char/serial.c.orig	Fri Sep 28 13:57:02 2001
> +++ linux/drivers/char/serial.c	Fri Sep 28 13:46:41 2001
> @@ -4015,7 +4015,10 @@
>   * seems to be mainly needed on card using the PLX which also use I/O
>   * mapped memory.
>   */
> -static int __devinit
> +static int
> +#ifndef MODULE
> +__devinit
> +#endif
>  pci_plx9050_fn(struct pci_dev *dev, struct pci_board *board, int enable)
>  {
>  	u8 data, *p, irq_config;

Are these actually needed?  They really shouldn't be...

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/