RFC: i8259.c cleanup

Gabriel Paubert paubert at iram.es
Wed Nov 7 20:40:57 EST 2001

On Wed, 7 Nov 2001, Geert Uytterhoeven wrote:

> On Wed, 7 Nov 2001, Dan Malek wrote:
> > hollis at austin.ibm.com wrote:
> > > The following patch (to linuxppc_2_4_devel) does exactly that - it reads from
> > > 0xbffffff0 instead of the 8259 directly.
> >
> > Ummmmm.....this probably works OK on PReP, but I don't think it is going
> > to have the desired effect on other systems using an 8259 :-).  You need
> > to find a way to to make the code you changed unique to PReP.
> Note that CHRP already has such a thing (chrp_int_ack_special), to be used with
> OpenPIC (it's passed to openpic_init()).

Indeed, what the 8259.c code might do is use the hardware address and
fall back to polling if the address is NULL. But to avoid run time
checking and minmize icache footprint, the two cases could be considered
as different interrupt controllers.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

More information about the Linuxppc-dev mailing list