ieee1394 fixed soon...

[David S. Miller]

Daniel Berlin writes:
 > As sopon as the the ieee1394 maintainer gets on the ball, i'll submit
 > them again.

If they continue to be unresponsive, I can ask Linus what we
as maintainers should do.

 > > 	p->value &= cpu_to_le32(0xfffffff0);
 > >
 > > works _PERFECTLY_ fine.

 > Not for me

This is mathmatically impossible.  :-)  Something else has to account
for it.

Maybe, you were hitting a compiler bug or similar, but you were not
hitting a problem because the logic is wrong.

 > I'm pretty sure, however, that I did that change
 > individually, and it made a difference.

Please verify this now, and check for miscompilation if you still
see the problem.

 > > I know what needs to be swapped thats why I did the patches I did :-)
 >
 > It's trickier than you may think, because motherboard implementations of
 > firewire aren't required to honor the byte swapping setting, making it
 > pretty useless.

I've read this paragraph of the OHCI specification.  Find me a
motherboard controller found on a big-endian system which does
not implement this bit, then I will begin to be concerned.

 > sure, as soon as they start actually maintaining ieee1394.

Why don't we contact them and give them a week, explaining that if
they don't wish to be active in ieee1394 driver maintainence then you
and I are willing to help more actively co-maintain the ieee1394 layer
together. :-)

Later,
David S. Miller
davem at redhat.com

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/