Crash on BenH's latest rsync (2.4.6-pre3)

Stephen R Marenka stephen at marenka.net
Thu Jun 28 02:25:42 EST 2001


On Tue, Jun 26, 2001 at 05:31:23PM -0500, Takashi Oe wrote:
> 
> On Tue, 26 Jun 2001 15:13:46 -0700, Tom Rini wrote:
> 
> > On Tue, Jun 26, 2001 at 04:29:13PM -0500, Takashi Oe wrote:
> >
> > > BootX support on your rsync tree and linuxppc_2_4_devel tree is
> > > broken.  I guess no one with BootX bothered to try
> > > linuxppc_2_4_devel..
> >
> > Does this work as well?
> 
> It sure does, though we might as well do:
> 
> 	if (boot_infos) {
> 		_machine = _MACH_Pmac;
> 		relocate_nodes();
> 	}
> 
> or similar as calling intuit_machine_type() is silly on BootX ;)

If I understand correctly, this failed for me because this causes 
relocate_nodes to get called again if have_of.

The following does work for me.

 	if (boot_infos) {
 		_machine = _MACH_Pmac;
                if ( !have_of )
 		    relocate_nodes();
 	}

Thanks,

Stephen

-- 
Stephen R. Marenka     If life's not fun, you're not doing it right!
<stephen at marenka.net>


More information about the Linuxppc-dev mailing list