dmasound module on PowerBook

[Geert Uytterhoeven]

In arch/ppc/kernel/feature.c, we have

    #ifdef CONFIG_PMAC_PBOOK
    #ifdef CONFIG_DMASOUND_MODULE
	    /* On PowerBooks, we disable the sound chip when dmasound is a module
	     * */
	    if (controller_count && find_devices("via-pmu") != NULL) {
		    feature_clear(controllers[0].device, FEATURE_Sound_power);
		    feature_clear(controllers[0].device, FEATURE_Sound_CLK_enable);
	    }
    #endif
    #endif

Shouldn't the sound chip be disabled if dmasound is not compiled at all, i.e.
#if defined(CONFIG_PMAC_PBOOK) && !defined(CONFIG_DMASOUND)?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Linux/{m68k~Amiga,PPC~CHRP} -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/