insw/outsw in ide.h

Geert Uytterhoeven geert at linux-m68k.org
Thu Mar 2 00:07:11 EST 2000


On Wed, 1 Mar 2000, Gary Thomas wrote:
> On 01-Mar-00 Paul Mackerras wrote:
> > Is there any PPC platform that needs to use a byte-swapping insw/outsw in
> > the IDE driver?  (I can't see why any platform would, but you never
> > know...)
> >
> > I have changed the insw/outsw/insl/outsl in include/asm-ppc/io.h to be the
> > non-swapping form (in my tree at least, I'll push it to bk soon).  I would
> > like to take out the special definitions of insw/outsw in
> > include/asm-ppc/ide.h and just let the ide driver use the standard
> > (non-swapping) form.  Will this cause a problem for any PPC platforms?
>
> I can't tell for sure, but won't this break existing [already installed]
> systems?  I agree that the data path really doesn't matter, but once it's
> on the media it probably does.
>
> Have you tested this change on a system with an IDE drive that has a
> live file system in place?

I know some people who formatted their disks on ia32 boxes and transferred them
to their CHRP boxes later, so the current code should work.

An easy way to find out is to try to mount a CD-ROM in an IDE CD-ROM drive. If
it works, endianness is OK.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Linux/{m68k~Amiga,PPC~CHRP} -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-dev mailing list