Recent controlfb.c change in BK's linuxppc_2_3

Benjamin Herrenschmidt bh40 at calva.net
Thu Jul 13 22:54:41 EST 2000


>
>I've just noticed that the function, control_vram_reqd() was renamed to
>control_vram_read() in BK tree.  The function is supposed to calculate the
>amound of VRAM required for given vmode and cmode.  That's why it was
>named that *_reqd().  AFAICS, *_read() naming has no meaning and
>misleading.  Please change it back or rename it to something better.

Oops, sorry... q vs. a is a comon typo here in France, and I incorrectly
"fixed" this without looking the code too closely. I'll put a more
explicit name.

Thanks.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-dev mailing list