kerne-2.4.0-test13pre3 with gcc-2.97

Alexandre Oliva aoliva at redhat.com
Sun Dec 24 14:29:32 EST 2000


On Dec 23, 2000, Kaoru Fukui <k_fukui at highway.ne.jp> wrote:

> -		unsigned char b[0];
> +		unsigned char *b;

This change (and apparently all other changes you've made) are
definitely wrong.  Zero-sized arrays as the last element of a
structure used to be an extension in GCC 2.95.2, that has been adopted
by C99 with a slightly different syntax, that GCC CVS supports: just
remove the `0' from between the braces.

With your change, you're changing what is supposed to be a structure
whose last element is a flexible array with a structure that ends with
a pointer to such an array, which means the array should be allocated
separately, and any access to it must de-reference an additional
pointer.  You'd have to adjust all uses of such a pointer to make this
change.  Could this be the reason why your modified kernel doesn't
work?

--
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/





More information about the Linuxppc-dev mailing list