rtc again...

[Takashi Oe]

On Fri, 4 Aug 2000, Franz Sirl wrote:

> At 01:33 04.08.00, Takashi Oe wrote:
>
> >On Thu, 3 Aug 2000, Gabriel Paubert wrote:
> >
> > > ===== arch/ppc/kernel/pmac_time.c 1.2 vs 1.5 =====
> > > --- 1.2/arch/ppc/kernel/pmac_time.c   Mon Jun 19 19:59:36 2000
> > > +++ 1.5/arch/ppc/kernel/pmac_time.c   Mon Jul 31 11:28:27 2000
> >[...]
> > >  int pmac_set_rtc_time(unsigned long nowtime)
> > >  {
> > > -     return 0;
> > > +#ifdef CONFIG_ADB
> > > +     struct adb_request req;
> > > +#endif
> > > +     nowtime += RTC_OFFSET - sys_tz.tz_minuteswest * 60;
> >         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >This needs to be changed to
> >
> >+       nowtime += RTC_OFFSET - sys_tz.tz_minuteswest * 60 +
> >(sys_tz.tz_dsttime? 3600: 0);
>
> No, don't handle DST in the kernel!! hwclock handles this in userland, see
> the hwclock source for details.

Oh, "nowtime" is UTC + DST fix up then???  If so, that seems to be broken
to me.


Takashi Oe


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/