Complete fix for PB 2400 16-bit video problem

[Geert Uytterhoeven]

On Tue, 8 Dec 1998, Timothy A. Seufert wrote:
> I figured out why 16-bit doesn't work in the console today.  I wasn't
> checking "Advanced driver options" in the console setup screen (I use make
> menuconfig).  This resulted in CONFIG_FBCON_CFB16 (I think that's the name)
> not getting set, which .  Perhaps the CONFIG_FBCON_CFBxx settings should
> default to Y?

You're right. If CONFIG_FB_CT65550 is enabled but Advanced driver options
isn't, it should enable support for cfb8 and cfb16 automatically. I'll fix
that.

> Also, since I proved in my earlier message that I didn't know how to use
> diff, and got told about it :), here is a better diff for
> drivers/video/chipsfb.c.  This will patch it to correctly change bitdepth.
> 
> 
> ---------cut-----------------
> --- chipsfb.orig.c	Mon Dec  7 00:24:13 1998
> +++ chipsfb.c	Mon Dec  7 01:27:17 1998
> @@ -358,6 +358,7 @@
>  		if (con == currcon) {
>  			write_cr(0x13, 200);		// 16 bit display
> width (decimal)
  ^^^^^^^^^^^^^^^
Please use a mailer that doesn't wrap long lines, since patch doesn't like
that.

>  			write_xr(0x81, 0x14);		// 15 bit
> (TrueColor) color mode
> +			write_xr(0x82, 0x00);		// disable palettes
>  			write_xr(0x20, 0x10);		// 16 bit blitter mode
>  		}
> 
> @@ -379,6 +380,7 @@
                 ^
>  		if (con == currcon) {
>  			write_cr(0x13, 100);		// 8 bit display
> width (decimal)
>  			write_xr(0x81, 0x12);		// 8 bit color mode
> +			write_xr(0x82, 0x08);		// Graphics gamma
> enable
>  			write_xr(0x20, 0x00);		// 8 bit blitter mode
>  		}
> ---------cut-----------------
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You cut an important empty line. The `7' means the patch hunk will result in
_7_ lines, not 6.

Greetings,

						Geert

--
Geert Uytterhoeven                     Geert.Uytterhoeven at cs.kuleuven.ac.be
Wavelets, Linux/{m68k~Amiga,PPC~CHRP}  http://www.cs.kuleuven.ac.be/~geert/
Department of Computer Science -- Katholieke Universiteit Leuven -- Belgium


[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to  Cc linuxppc-dev  if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request at lists.linuxppc.org ]]