[PATCH net mlxsw v3 3/4] mlxsw: core_acl_flex_actions: Remove redundant counter destruction

Nir Dotan nird at mellanox.com
Wed Aug 1 18:24:54 AEST 2018


Each tc flower rule uses a hidden count action. As counter
resource may not be available due to limited HW resources, update
_counter_create() and _counter_destroy() pair to follow previously introduced
symmetric error condition handling, add a call to mlxsw_afa_resource_del()
as part of the counter resource destruction.

Fixes: c18c1e186ba8 ("mlxsw: core: Make counter index allocated inside the action append")
Signed-off-by: Nir Dotan <nird at mellanox.com>
Reviewed-by: Petr Machata <petrm at mellanox.com>
---

Notes:
    v2:
    * Split this patch from patch #2
    
    v3:
    * Rephrase commit text

 drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c b/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
index d664cc0..a54f23f 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
@@ -584,6 +584,7 @@ static void
 mlxsw_afa_counter_destroy(struct mlxsw_afa_block *block,
 			  struct mlxsw_afa_counter *counter)
 {
+	mlxsw_afa_resource_del(&counter->resource);
 	block->afa->ops->counter_index_put(block->afa->ops_priv,
 					   counter->counter_index);
 	kfree(counter);
-- 
2.8.4



More information about the Linux-mlxsw mailing list