[PATCH net-next mlxsw v2 5/7] mlxsw: spectrum: Pass switchdev VLAN object to SPAN respin

Ido Schimmel idosch at mellanox.com
Wed Apr 25 17:27:40 AEST 2018

On Wed, Apr 25, 2018 at 01:09:07AM +0200, Petr Machata wrote:
> Because switchdev events are emitted before the changes are applied to
> the bridge, mlxsw_sp_span_entry_ops.parms() callback wouldn't see the
> updated value of VLAN flags when respinning due to change in those
> flags.
> Thus add a parameter of type struct switchdev_obj_port_vlan to
> mlxsw_sp_span_respin() and propagate to the parms callback. Pass NULL
> from all current callers.

Seven out of eight call sites specify NULL. Better to create
mlxsw_sp_span_vlan_respin() and leave the other call sites intact.

More information about the Linux-mlxsw mailing list