[RFC PATCH 2/2] fsi: Move master attributes to fsi-master class

Jeremy Kerr jk at ozlabs.org
Fri Sep 20 19:16:06 AEST 2019


Hi Greg,

> No Documentation/ABI/ update for where these files have now moved to?

Ah, I had assumed that the layout under /sys/devices/ is unchanged, but
it looks like the addition of the class (in patch 1/2) does bump them to
a class directory. ie., this changes:

 /sys/devices/<path>/<master-node>/fsiN 

to:

 /sys/devices/<path>/<master-node>/fsi-master/fsiN

We could provide compat through a symlink though, would that be
sensible?

> Are you going to break userspace tools that were expecting them in
> another location?

I'd rather not, if it's avoidable. However, those tools would already be
assuming a pre-defined /sys/devices/ layout, as <path> above is defined
by the hardware implementations (and device tree names..).

Cheers,


Jeremy



More information about the Linux-fsi mailing list