[PATCH v15 2/9] erofs: decouple `struct erofs_anon_fs_type`

Hongbo Li lihongbo22 at huawei.com
Mon Jan 19 13:23:19 AEDT 2026


Hi,

On 2026/1/19 9:44, Gao Xiang wrote:
> 
> 
> On 2026/1/19 09:34, Hongbo Li wrote:
>> Hi, Xiang
>>
>> On 2026/1/16 23:38, Christoph Hellwig wrote:
>>>> +#if defined(CONFIG_EROFS_FS_ONDEMAND)
>>>
>>> Normally this would just use #ifdef.
>>>
>> How about using #ifdef for all of them? I checked and there are only 
>> three places in total, and all of them are related to 
>> FS_PAGE_CACHE_SHARE or FS_ONDEMAND config macro.
> 
> I'm fine with most cases (including here).
> 
> But I'm not sure if there is a case as `#if defined() || defined()`,
> it seems it cannot be simply replaced with `#ifdef`.
> 
Yeah, we cannot replace it in this case. So I will keep it here because 
it will be changed into `#if defined() || defined()` in following steps. 
Instead, I will use this way in other place, such as:

```
#if defined(CONFIG_EROFS_FS_PAGE_CACHE_SHARE)
                 set_opt(&sbi->opt, INODE_SHARE);
#else
...
```

Thanks,
Hongbo


> Thanks,
> Gao Xiang
> 
>>
>> Thanks,
>> Hongbo
> 


More information about the Linux-erofs mailing list