[PATCH 2/3] erofs-utils: lib: avoid using lseek in diskbuf

[zhaoyifan (H)]

thanks, will take a look


Yifan Zhao

On 2025/9/22 10:37, Gao Xiang wrote:
>
>
> On 2025/9/18 23:12, Yifan Zhao wrote:
>> From: zhaoyifan <zhaoyifan28 at huawei.com>
>>
>> The current `diskbuf` implementation uses `lseek` to operate file 
>> offset,
>> preventing multiple streams from writing to the same file. Let's replace
>> `write` + `lseek` with `pwrite` to enable this use pattern.
>>
>> Signed-off-by: Yifan Zhao <zhaoyifan28 at huawei.com>
>
> It seems this patch breaks CI,
> https://github.com/erofs/erofsnightly/actions/runs/17902749255/job/50898433325 
>
>
> 2025-09-22T02:28:33.7178065Z Processing 
> linux-5.4.256/virt/kvm/arm/vgic/vgic-v3.c ...
> 2025-09-22T02:28:33.7178615Z Processing 
> linux-5.4.256/virt/kvm/arm/vgic/vgic-v4.c ...
> 2025-09-22T02:28:33.7179125Z Processing 
> linux-5.4.256/virt/kvm/arm/vgic/vgic.c ...
> 2025-09-22T02:28:33.7179623Z Processing 
> linux-5.4.256/virt/kvm/arm/vgic/vgic.h ...
> 2025-09-22T02:28:33.7180092Z Processing linux-5.4.256/virt/lib/Kconfig 
> ...
> 2025-09-22T02:28:33.7180516Z Processing 
> linux-5.4.256/virt/lib/Makefile ...
> 2025-09-22T02:28:33.7180965Z Processing 
> linux-5.4.256/virt/lib/irqbypass.c ...
> 2025-09-22T02:28:33.7181377Z Build completed.
> 2025-09-22T02:28:33.7181556Z
> 2025-09-22T02:28:33.7181658Z ------
> 2025-09-22T02:28:33.7181969Z Filesystem UUID: 
> 83e743e1-72ca-40cb-bc27-7621af1f88fc
> 2025-09-22T02:28:33.7182448Z Filesystem total blocks: 239166 (of 
> 4096-byte blocks)
> 2025-09-22T02:28:33.7182882Z Filesystem total inodes: 70074
> 2025-09-22T02:28:33.7183231Z Filesystem total metadata blocks: 2060
> 2025-09-22T02:28:33.7183705Z Filesystem total deduplicated bytes (of 
> source files): 1021788
> 2025-09-22T02:28:33.8980774Z erofsfuse 1.8.10-g475e9afd
> 2025-09-22T02:28:33.8981380Z <W> erofs: main() Line[755] 
> lowerdir.erofs.img mounted on lowerdir with offset 0
> 2025-09-22T02:28:34.0928040Z Makefile:1: *** missing separator. Stop.
>
> ...
>
> Thanks,
> Gao Xiang