[PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

[Gao Xiang]

On 2025/3/9 21:40, Yunsheng Lin wrote:
> On 3/8/2025 2:43 PM, Dave Chinner wrote:
> 
> ...
> 
>>> I tested XFS using the below cmd and testcase, testing seems
>>> to be working fine, or am I missing something obvious here
>>> as I am not realy familiar with fs subsystem yet:
>>
>> That's hardly what I'd call a test. It barely touches the filesystem
>> at all, and it is not exercising memory allocation failure paths at
>> all.
>>
>> Go look up fstests and use that to test the filesystem changes you
>> are making. You can use that to test btrfs and NFS, too.
> 
> Thanks for the suggestion.
> I used the below xfstests to do the testing in a VM, the smoke testing
> seems fine for now, will do a full testing too:
> https://github.com/tytso/xfstests-bld
> 
> Also, it seems the fstests doesn't support erofs yet?

erofs is an read-only filesystem, and almost all xfstests
cases is unsuitable for erofs since erofs needs to preset
dataset in advance for runtime testing and only
read-related interfaces are cared:

You could check erofs-specfic test cases here:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/log/?h=experimental-tests

Also the stress test:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=6fa861e282408f8df9ab1654b77b563444b17ea1

BTW, I don't like your new interface either, I don't know
why you must insist on this work now that others are
already nak this.  Why do you insist on it so much?

Thanks,
Gao Xiang

> 
>>
>> -Dave.
>>