[PATCH v2] erofs: support metadata compression

Gao Xiang hsiangkao at linux.alibaba.com
Mon Jul 14 13:15:37 AEST 2025


..

>>       if (!name)
>>           return -EINVAL;
>> @@ -411,9 +416,12 @@ int erofs_getxattr(struct inode *inode, int index, const char *name,
>>       if (it.name.len > EROFS_NAME_LEN)
>>           return -ERANGE;
>> +    if (erofs_sb_has_xattr_compr(sbi))
> 
> Is xattr_compr another feature under meta compr? In my opinion, how about splitting it with another patch?

Just answer this in advance, it should be in this patch, or
as a seperate patch before this patch.

Otherwise it's non-bisectable (and thus causes a incompat
feature) because users could use a kernel with metadata
compression but without erofs_sb_has_xattr_compr, it
causes the connected features fragmented.

Thanks,
Gao Xiang

> 
> Thanks,
> Hongbo
> 


More information about the Linux-erofs mailing list