[PATCH v6 3/4] erofs-utils: mkfs: introduce --s3=... option

[Gao Xiang]

On 2025/8/7 11:43, Hongbo Li wrote:
> Hi Xiang,
> 
> On 2025/8/7 11:08, Gao Xiang wrote:
>> From: Yifan Zhao <zhaoyifan28 at huawei.com>
>>
>> It introduces configuration options for the upcoming experimental S3
>> support, including configuration parsing and `passwd_file` reading
>> logic.
>>
>> Users can specify the following options:
>>   - S3 service endpoint (required);
>>   - S3 credentials file in the format $ak:%sk (optional);
>>   - S3 API calling style (optional);
>>   - S3 API signature version (optional, only V2 is currently supported).
>>
>> Signed-off-by: Yifan Zhao <zhaoyifan28 at huawei.com>
>> Signed-off-by: Gao Xiang <hsiangkao at linux.alibaba.com>
>> ---
>>   lib/liberofs_s3.h |  40 ++++++++
>>   mkfs/main.c       | 226 +++++++++++++++++++++++++++++++++++++++-------
>>   2 files changed, 234 insertions(+), 32 deletions(-)
>>   create mode 100644 lib/liberofs_s3.h
>>
>> diff --git a/lib/liberofs_s3.h b/lib/liberofs_s3.h
>> new file mode 100644
>> index 0000000..fbf2f80
>> --- /dev/null
>> +++ b/lib/liberofs_s3.h
> 
> How about moving liberofs_s3.h to `include/erofs/`? Because s3erofs_build_trees can also be exported and used in other cases.

Public APIs need to be redesigned later, current APIs
are unfriendly for external uses.

I tend to export a common api set to import data from:
  localdir
  tar / cpio / ...
  s3
  oci
  etc.

Thanks,
Gao Xiang