[PATCH v4] erofs: lazily initialize per-CPU workers and CPU hotplug hooks
Gao Xiang
hsiangkao at linux.alibaba.com
Thu Apr 24 10:31:42 AEST 2025
On 2025/4/23 14:10, Sandeep Dhavale wrote:
> Currently, when EROFS is built with per-CPU workers, the workers are
> started and CPU hotplug hooks are registered during module initialization.
> This leads to unnecessary worker start/stop cycles during CPU hotplug
> events, particularly on Android devices that frequently suspend and resume.
>
> This change defers the initialization of per-CPU workers and the
> registration of CPU hotplug hooks until the first EROFS mount. This
> ensures that these resources are only allocated and managed when EROFS is
> actually in use.
>
> The tear down of per-CPU workers and unregistration of CPU hotplug hooks
> still occurs during z_erofs_exit_subsystem(), but only if they were
> initialized.
>
> Signed-off-by: Sandeep Dhavale <dhavale at google.com>
Reviewed-by: Gao Xiang <hsiangkao at linux.alibaba.com>
> ---
...
> int z_erofs_init_super(struct super_block *sb)
> {
> - struct inode *const inode = new_inode(sb);
> + struct inode *inode;
> + int err;
>
> + err = z_erofs_init_pcpu_workers();
> + if (err)
> + return err;
> +
> + inode = new_inode(sb);
> if (!inode)
> return -ENOMEM;
> +
I think the new blank line is redundant, the setup part
should be next to new_inode().
I could fix up this part manually if you don't have strong
opinion on this.
Thanks,
Gao Xiang
More information about the Linux-erofs
mailing list