[PATCH v6.6] erofs: fix NULL dereference of dif->bdev_handle in fscache mode

Gao Xiang hsiangkao at linux.alibaba.com
Fri Jun 28 00:03:38 AEST 2024



On 2024/6/27 21:22, Greg KH wrote:
> On Thu, Jun 27, 2024 at 08:51:37PM +0800, Gao Xiang wrote:
>>
>>
>> On 2024/6/27 20:36, Gao Xiang wrote:
>>> Hi Greg,
>>>
>>> On 2024/6/27 19:16, Greg KH wrote:
>>
>> ...
>>
>>>>
>>>> So what specifically should we do here?
>>>
>>> Thanks for the reply..  Honestly I'd like to revert
>>>
>>> block: Provide bdev_open_* functions
>>> erofs: Convert to use bdev_open_by_path()
>>> erofs: fix handling kern_mount() failure
>>>
>>> Not quite sure if they can be cleanly reverted, but
>>> since the upstream doen't have 'bdev_handle' anymore,
>>> I will resend a proper backport for
>>> "erofs: fix handling kern_mount() failure".
>>
>> Sigh, I just tried and it seems it causes more
>> conflicts due to my revert.  It seems another churn..
>>
>> Anyway, on 6.6 LTS only the erofs one uses the
>> obsolete `struct bdev_handle`, but I think at least
>> it doesn't cause some serious issue.
>>
>> Hi Greg,
>>
>> Could you just pick up Hongbo's backport to resolve
>> the NULL dereference issue?
> 
> Sure, is that the one earlier in this thread?

Yeah.

> 
> And if so, what is the git commit id of it in Linus's tree?

commit 8bd90b6ae7856dd5000b75691d905b39b9ea5d6b upstream.

Thanks,
Gao Xiang

> 
> thanks,
> 
> greg k-h


More information about the Linux-erofs mailing list