[PATCH] vfs: Fix potential circular locking through setxattr() and removexattr()

David Howells dhowells at redhat.com
Wed Jul 24 18:11:16 AEST 2024


Jan Kara <jack at suse.cz> wrote:

> > +	error = strncpy_from_user(kname, name, sizeof(kname));
> > +	if (error == 0 || error == sizeof(kname))
> > +		error = -ERANGE;
> > +	if (error < 0)
> > +		return error;
> 
> Missing fdput() here.

Thanks.  I think Christian is altering the patch to use auto-destruction
constructs (CLASS()).

David



More information about the Linux-erofs mailing list