[PATCH] [PATCH v1] erofs-utils: add OCI registry support

[Gao Xiang]

On 2024/7/11 13:42, saz97 wrote:
> From: Changzhi Xie <sa.z at qq.com>


The patch title is still wrong:
[PATCH] [PATCH v1] erofs-utils: add OCI registry support

should be
[PATCH] erofs-utils: add OCI registry support
or
[PATCH v1] erofs-utils: add OCI registry support

> 
> This patch adds support for handling OCI registry operations in the EROFS. The following functionalities are included:
> 
> 1. `oci_registry_read`: Reads data from the OCI registry memory structure.
> 2. `oci_registry_pread`: Reads data from a specified offset within the OCI registry memory structure.
> 3. `oci_registry_lseek`: Adjusts the file offset within the OCI registry memory structure.
> 4. `open_oci_registry`: Main function to handle the opening of the OCI registry.
> 
> These changes include the following adjustments:
> - Renaming structures and functions to follow the EROFS naming conventions.
> 
> Signed-off-by: Changzhi Xie <sa.z at qq.com>
> ---
>   include/erofs/io.h |   1 -
>   lib/oci_registry.c | 183 ++++++++++++++++++---------------------------
>   2 files changed, 73 insertions(+), 111 deletions(-)
> 
> diff --git a/include/erofs/io.h b/include/erofs/io.h
> index e8b6008..f53abed 100644
> --- a/include/erofs/io.h
> +++ b/include/erofs/io.h
> @@ -16,7 +16,6 @@ extern "C"
>   #define _GNU_SOURCE
>   #endif
>   #include <unistd.h>
> -
>   #include "defs.h"
>   
>   #ifndef O_BINARY
> diff --git a/lib/oci_registry.c b/lib/oci_registry.c
> index 37fe357..3c21e2d 100644
> --- a/lib/oci_registry.c
> +++ b/lib/oci_registry.c
> @@ -10,24 +10,23 @@
>   #define MANIFEST_MODE 3
>   #define BLOB_MODE 4
>   
> -struct MemoryStruct {
> +struct erofs_oci_registry_memory {
>       char *memory;
>       size_t size;
>   };
>   
> -CURLM *get_multi_handle() {
> +CURLM *erofs_oci_registry_get_multi_handle(void) {

Why it still have a diff?

Could you send it to your email privately (and try to `git am`
first on -dev branch) before sending out to the mailing list?

Thanks,
Gao Xiang