[PATCH] erofs: make erofs_err() and erofs_info() support NULL sb parameter

[Gao Xiang]

On 2024/1/2 22:37, Chunhai Guo wrote:
> Make erofs_err() and erofs_info() support NULL sb parameter for more
> general usage.
> 
> Suggested-by: Gao Xiang <xiang at kernel.org>
> Signed-off-by: Chunhai Guo <guochunhai at vivo.com>
> ---
>   fs/erofs/super.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 3789d6224513..96a9d19de96b 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -27,7 +27,11 @@ void _erofs_err(struct super_block *sb, const char *func, const char *fmt, ...)
>   	vaf.fmt = fmt;
>   	vaf.va = &args;
>   
> -	pr_err("(device %s): %s: %pV", sb->s_id, func, &vaf);
> +	if (sb)
> +		pr_err("(device %s): %s: %pV", sb->s_id, func, &vaf);
> +	else
> +		pr_err("%s: %pV", func, &vaf);
> +

redundant line, otherwise looks good to me.

Thanks,
Gao Xiang

>   	va_end(args);
>   }
>   
> @@ -41,7 +45,10 @@ void _erofs_info(struct super_block *sb, const char *func, const char *fmt, ...)
>   	vaf.fmt = fmt;
>   	vaf.va = &args;
>   
> -	pr_info("(device %s): %pV", sb->s_id, &vaf);
> +	if (sb)
> +		pr_info("(device %s): %pV", sb->s_id, &vaf);
> +	else
> +		pr_info("%pV", &vaf);
>   	va_end(args);
>   }
>