[PATCH v3 0/4] erofs-utils: mkfs: introduce multi-threaded compression

Yifan Zhao zhaoyifan at sjtu.edu.cn
Thu Feb 29 15:33:39 AEDT 2024


On 2/29/24 11:12, Noboru Asai wrote:
>> - remove inter-file compression support from this patchset
> Do you have any problems about inter-file compression functionarity?
> Or make steps (split this functionarity as separate patch set)?
> I'm testing v1 patch set and I have no problem like making wrong images for now.
> (I couldn't apply v2 patch set without rejects.)
>
> 2024年2月25日(日) 23:28 Yifan Zhao <zhaoyifan at sjtu.edu.cn>:
>
We split the inter-file compression functionality as a separate patch 
set for ease of review. It will be re-sent shortly (maybe a few days) 
after we finish polishing the inner-file patch set.

I am sorry that the v2 patchset cannot be cleanly applied due to my 
missteps, and I believe the latest one (v4) works. Thank you for your 
testing!


Thanks,

Yifan Zhao

>> change log since v2:
>> - squash per-worker tmpfile commit into previous PATCH
>> - give static global variable `erofs_` prefix
>> - remove inter-file compression support from this patchset
>> - introduce a new `z_erofs_file_compress_ctx` struct to divide the segment
>>    context from the file context
>> - remove the patch related to pring warning from this patchset, which may be
>>    supported later with atomic variables
>>
>> Gao Xiang (1):
>>    erofs-utils: add a helper to get available processors
>>
>> Yifan Zhao (3):
>>    erofs-utils: introduce multi-threading framework
>>    erofs-utils: mkfs: add --worker=# parameter
>>    erofs-utils: mkfs: introduce inner-file multi-threaded compression
>>
>>   configure.ac              |  17 +
>>   include/erofs/compress.h  |   1 +
>>   include/erofs/config.h    |   5 +
>>   include/erofs/internal.h  |   3 +
>>   include/erofs/workqueue.h |  37 ++
>>   lib/Makefile.am           |   4 +
>>   lib/compress.c            | 690 +++++++++++++++++++++++++++++++-------
>>   lib/compressor.c          |   2 +
>>   lib/config.c              |  16 +
>>   lib/workqueue.c           | 132 ++++++++
>>   mkfs/main.c               |  38 +++
>>   11 files changed, 827 insertions(+), 118 deletions(-)
>>   create mode 100644 include/erofs/workqueue.h
>>   create mode 100644 lib/workqueue.c
>>
>> --
>> 2.44.0
>>


More information about the Linux-erofs mailing list