[PATCH] erofs-utils: mkfs: make output stable

Gao Xiang hsiangkao at linux.alibaba.com
Tue Dec 3 18:54:08 AEDT 2024



On 2024/12/3 15:45, Jooyung Han wrote:
> The iteration order of opendir/readdir depends on filesystem
> implementation. Initializng inode->i_ino[0] in the loop causes the
> output unstable even though the entries are sorted in
> erofs_prepare_dir_file().
> 
> In this change,  inode->i_ino[0] is initialized in
> erofs_prepare_inode_buffer() instead to make the output stable. (not
> affected by readdir())
> 
> Test: mkfs.erofs ... inputdir(ext3)
> Test: mkfs.erofs ... inputdir(tmpfs)
>    # should generate the same output
> Change-Id: I41bb8d5487a77b83dfa69d3d085e38223ab17f87
> Signed-off-by: Jooyung Han <jooyung at google.com>

Thanks, applied without `Change-Id` tag.

Thanks,
Gao Xiang


More information about the Linux-erofs mailing list