[PATCH] Prevent entering an infinite loop when i is 0

liujinbao1 jinbaoliu365 at gmail.com
Thu Aug 22 16:27:49 AEST 2024


From: liujinbao1 <liujinbao1 at xiaomi.com>

When i=0 and err is not equal to 0,
the while(-1) loop will enter into an
infinite loop. This patch avoids this issue.
---
 fs/erofs/decompressor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
index c2253b6a5416..1b2b8cc7911c 100644
--- a/fs/erofs/decompressor.c
+++ b/fs/erofs/decompressor.c
@@ -539,6 +539,8 @@ int __init z_erofs_init_decompressor(void)
 	for (i = 0; i < Z_EROFS_COMPRESSION_MAX; ++i) {
 		err = z_erofs_decomp[i] ? z_erofs_decomp[i]->init() : 0;
 		if (err) {
+			if (!i)
+				return err;
 			while (--i)
 				if (z_erofs_decomp[i])
 					z_erofs_decomp[i]->exit();
-- 
2.25.1



More information about the Linux-erofs mailing list