[PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled
Gao Xiang
hsiangkao at linux.alibaba.com
Tue May 23 11:53:06 AEST 2023
On 2023/5/23 17:52, Yue Hu wrote:
> On Mon, 22 May 2023 17:21:41 +0800
> Gao Xiang <hsiangkao at linux.alibaba.com> wrote:
>
>> As Sandeep shown [1], high priority RT per-cpu kthreads are
>> typically helpful for Android scenarios to minimize the scheduling
>> latencies.
>>
>> Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if
>> EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for
>> EROFS_FS_PCPU_KTHREAD.
>>
>> Also clean up unneeded sched_set_normal().
>>
>> [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com
>> Cc: Sandeep Dhavale <dhavale at google.com>
>> Signed-off-by: Gao Xiang <hsiangkao at linux.alibaba.com>
>> ---
>> fs/erofs/Kconfig | 1 +
>> fs/erofs/zdata.c | 2 --
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig
>> index 704fb59577e0..f259d92c9720 100644
>> --- a/fs/erofs/Kconfig
>> +++ b/fs/erofs/Kconfig
>> @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD
>> config EROFS_FS_PCPU_KTHREAD_HIPRI
>> bool "EROFS high priority per-CPU kthread workers"
>> depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD
>> + default y
>
> How about removing this config option?
I tend to leave it as is.
Thanks,
Gao Xiang
More information about the Linux-erofs
mailing list