[PATCH v2 2/4] erofs-utils: lib: unify all identical compressor print function

Gao Xiang hsiangkao at linux.alibaba.com
Thu Jun 15 22:29:07 AEST 2023



On 2023/6/15 20:01, Guo Xuenan wrote:
> 
> On 2023/6/15 18:46, Gao Xiang wrote:

...


>>> +
>>> +void erofs_print_available_compressors(FILE *f)
>>> +{
>>
>> Should just erofs_print_supported_compressors(f, ~0) and avoid this helper?
>>
> As commit message of this patch explained, available compressors means which algothrims are
> currentlyavailable to user in binary tools. I mean fsck/mkfs.erofs binary tools may only support
> lz4 compression.erofs_print_available_compressors should only print lz4; but for dump.erofs ,
> which is not used tomake erofs image, there is a bit difference here. dump.erofs should identify
> all supportedalgorithms.

Oh, that makes sense, sorry about the noise.

>> Thanks,
>> Gao Xiang
>>
> -- 
> Best regards
> Guo Xuenan
> 


More information about the Linux-erofs mailing list