[PATCH] erofs-utils: dump: add some superblock fields display

Guo Xuenan guoxuenan at huaweicloud.com
Tue Jun 6 18:39:30 AEST 2023


On 2023/6/6 15:58, Gao Xiang wrote:
>
>
> On 2023/6/6 15:28, Guo Xuenan wrote:
>
> ...
>
>>>> +
>>>> +struct available_alg {
>>>> +    int type;
>>>> +    const char *name;
>>>> +};
>>>
>>> Could we use lib/compressor.c instead?
>>>
>> Take a look at the currently implemented interface, and I notice that
>> compressor.c define different compressors for mkfs.erofs, but for
>> dump.erofs we don't need care about that much, we only show compression
>>   algothrims name of the image. It seems that it cannot be reused.
>
> Please help add erofsfsck_ prefix to available_cfg like
> erofsfsck_available_cfg.
>
> Anyway, that is still not quite clean if you take a look at
> erofs_get_compress_algorithm_id() if lib/compress.c.
>
Okay, I will  reorganize the code here,  try to address it and send v2 
later.
> We could address this later.
>
> Thanks,
> Gao Xiang

-- 
Guo Xuenan [Confused at thirty]
-----------------------------
Email: guoxuenan at huaweicloud.com



More information about the Linux-erofs mailing list