[PATCH v2 1/3] erofs-utils: add xxh32 library

Jingbo Xu jefflexu at linux.alibaba.com
Wed Jul 12 21:58:00 AEST 2023



On 7/5/23 3:29 PM, Gao Xiang wrote:
> 
> 
> On 2023/7/5 15:10, Jingbo Xu wrote:
>> Add xxh32 library which could be used by following xattr bloom filter
>> feature.
>>
>> Signed-off-by: Jingbo Xu <jefflexu at linux.alibaba.com>
> 
> I'd suggest using the original xxhash library instead of copying an
> simplified implementation here since we don't touch the implementation.
> 
> https://rpmfind.net/linux/rpm2html/search.php?query=xxhash

Yeah.  I think xxhash-devel is available in most distributions.  XXH32()
could be used directly here and configure.ac needs to be updated to
reflect the package dependency.

As I'm not quite familiar with autoconf/automake, later in v3 I will
still attach the self-implemented xxh32() in erofs-utils.  Maybe later
we could change to use libxxhash directly.


-- 
Thanks,
Jingbo


More information about the Linux-erofs mailing list